[TASK] Simplify frontend page generation code 84/56884/4
authorHelmut Hummel <typo3@helhum.io>
Tue, 1 May 2018 16:57:06 +0000 (18:57 +0200)
committerMarkus Klein <markus.klein@typo3.org>
Wed, 9 May 2018 07:44:31 +0000 (09:44 +0200)
commit7a0b88dc117fcbfb40032ba5b706893b4b53b0b2
treebad103cb22625fa0c1188e87ce46690da325f4de
parent2cdbfde97496fb527028148a5882447a706a9149
[TASK] Simplify frontend page generation code

The additional isINTincScript check stems from the time
where this code was in a separate file, which
was included two times and page generation should be
skipped for the second inclusion. As INT scripts are only generated
during page rendering (or when fetching the page from cache)
we can safely remove this condition now.

Additionally, we can now easily get rid of the elseif
and move the page rendering preparation directly
after the same condition is checked later in the code flow.

This is fine, because this code does not need to be
executed before the lock is released. Last but not least
we clean up admin panel messages to clearly distinguish
between page generation and rendering preparation.

As this is a pure non breaking cleanup, this can
safely go into 8.7 branch as well.

Resolves: #84945
Releases: master, 8.7
Change-Id: If12b82a549d4cc47619c46f73c5423df70621b1b
Reviewed-on: https://review.typo3.org/56884
Reviewed-by: Daniel Goerz <ervaude@gmail.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
typo3/sysext/frontend/Classes/Controller/TypoScriptFrontendController.php
typo3/sysext/frontend/Classes/Http/RequestHandler.php
typo3/sysext/frontend/Classes/Middleware/PrepareTypoScriptFrontendRendering.php