[BUGFIX] Make functional frontend tests work again 94/57894/2
authorHelmut Hummel <typo3@helhum.io>
Tue, 14 Aug 2018 13:31:26 +0000 (15:31 +0200)
committerAndreas Fernandez <a.fernandez@scripting-base.de>
Thu, 16 Aug 2018 10:19:40 +0000 (12:19 +0200)
commit720153a7a97f7e3ee5e5505396af5a51cfa0d5c1
treed47575c14915f156d8f0f166ce9d93ec884ff13e
parent945c43f2496d901be7db4eb1920f200781f40e9c
[BUGFIX] Make functional frontend tests work again

On systems that populate $_ENV['_'] with the path
to the PHP binary, frontend functional tests fail.

This is due to the fact that TYPO3 tries to determine paths
based on a cli environment, while we in fact emulate
a frontend (HTTP server) environment in this scenario.

This can be fixed with checking for the "magic"
context "Testing/Frontend", which was added beforehand
already in a different place.

At the same time we simplify the code used to make
functional tests work without process isolation, to
make it better communicate the intention and also
make it more robust.

Resolves: #85842
Related: #85712
Related: #85649
Releases: master
Change-Id: Ie1f9d220f70ecfe5ff00d8bf421e58df2b411d23
Reviewed-on: https://review.typo3.org/57894
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Reviewed-by: Riny van Tiggelen <info@online-gamer.nl>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
typo3/sysext/core/Classes/Core/SystemEnvironmentBuilder.php