[BUGFIX] Only count items in ForViewHelper when ``iteration`` argument is set 11/40711/3
authorMathias Brodala <mbrodala@pagemachine.de>
Mon, 29 Jun 2015 07:49:48 +0000 (09:49 +0200)
committerAnja Leichsenring <aleichsenring@ab-softlab.de>
Mon, 29 Jun 2015 12:48:18 +0000 (14:48 +0200)
commit6ea4f290564732cb04b36dcd24a0bad5ec20f98f
tree402952c1631020bed674df8705b3dc9881aa99c5
parent89139e81a49259ec03c5ea6b0c35734f9528f5f3
[BUGFIX] Only count items in ForViewHelper when ``iteration`` argument is set

When using the ``iteration`` argument, the ``ForViewHelper`` provides
information about the current iteration, including the ``cycle`` and
``total``. Therefore it needs to count all elements.
The problem is, that this happens even if the iteration argument is
not specified leading to performance issues especially when iterating
over a (subset of a) lot of (remote) items.

This patch fixes this by adding a check for the ``iteration`` argument.

Resolves: #67801
Releases: master, 6.2
Change-Id: I4645ed03322bea36f2c36263378900f401626f24
Reviewed-on: http://review.typo3.org/40711
Reviewed-by: David Greiner <hallo@davidgreiner.de>
Tested-by: David Greiner <hallo@davidgreiner.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
typo3/sysext/fluid/Classes/ViewHelpers/ForViewHelper.php
typo3/sysext/fluid/Tests/Unit/ViewHelpers/ForViewHelperTest.php