[TASK] Clean up ['ctrl'] sortby and default_sortby 08/52108/2
authorChristian Kuhn <lolli@schwarzbu.ch>
Mon, 20 Mar 2017 19:43:33 +0000 (20:43 +0100)
committerFrank Nägler <frank.naegler@typo3.org>
Wed, 22 Mar 2017 10:45:41 +0000 (11:45 +0100)
commit6bf6369fac4de67aafe30399e27eddd2b9c3f785
treeda0de80e3ebccdbc6e9e703b8288c7ea5c237b77
parent95d6b579dc0e757eaf9a6c1cd8859908eaa96e0c
[TASK] Clean up ['ctrl'] sortby and default_sortby

sortby: An integer field with an explicit sorting value

default_sortby: A query->orderBy statement to sort records
if no explicit sortby field is given.

default_sortby is ignored if sortby is given. The patch removes
a couple of TCA ['ctrl']['default_sortby'] declarations where both
were defined.

default_sortby needs no "ORDER BY" prefix. The patch removes it
from those TCA tables where this prefix was still defined.

Additionally, the TCA reference docs have been improved in this
area to hint about both fields and their correlation. It is especially
evil if that is confused and a field like 'title' is set as sortby:
The DataHandler would happily write integers into that field on save.

Change-Id: Ib5c38a538cd3f60d3e05033488363a144f756505
Resolves: #80361
Releases: master
Reviewed-on: https://review.typo3.org/52108
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Steffen Kamper <info@sk-typo3.de>
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Tested-by: Josef Glatz <josef.glatz@typo3.org>
Tested-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
Reviewed-by: Frank Nägler <frank.naegler@typo3.org>
Tested-by: Frank Nägler <frank.naegler@typo3.org>
13 files changed:
typo3/sysext/core/Configuration/TCA/be_groups.php
typo3/sysext/core/Configuration/TCA/be_users.php
typo3/sysext/core/Configuration/TCA/sys_collection.php
typo3/sysext/core/Configuration/TCA/sys_file.php
typo3/sysext/core/Configuration/TCA/sys_file_collection.php
typo3/sysext/core/Configuration/TCA/sys_file_metadata.php
typo3/sysext/core/Configuration/TCA/sys_file_storage.php
typo3/sysext/core/Configuration/TCA/sys_language.php
typo3/sysext/frontend/Configuration/TCA/fe_users.php
typo3/sysext/indexed_search/Configuration/TCA/index_config.php
typo3/sysext/rtehtmlarea/Configuration/TCA/tx_rtehtmlarea_acronym.php
typo3/sysext/sys_action/Configuration/TCA/sys_action.php
typo3/sysext/sys_note/Configuration/TCA/sys_note.php