[!!!][TASK] Always include pageId in cHash calculation 83/51883/5
authorBenni Mack <benni@typo3.org>
Tue, 28 Feb 2017 06:17:43 +0000 (07:17 +0100)
committerChristian Kuhn <lolli@schwarzbu.ch>
Wed, 1 Mar 2017 12:57:08 +0000 (13:57 +0100)
commit6a1b8e340e3e03de5a1e093eae3e5034202c0531
treed901aa7dfeba61172da519e7fd223def6980abfe
parent6d7b61941cae2bb41f1950241ed9430fa2775a10
[!!!][TASK] Always include pageId in cHash calculation

The option $TYPO3_CONF_VARS[FE][cHashIncludePageId]
was included as part of a security fix to stay backwards-compatible
with existing installations.

The option was only there as a intermediate step, however
the cHash calculation should always contain the pageID,
so the option is removed and should be enabled by default.

The change removes the option via a silent configuration
updater in the Install Tool, removes the status report and
changes the cHash calculation to always include a pageId,
and if the page ID is not given, an exception is now
thrown all the time.

Resolves: #80050
Releases: master
Change-Id: Iac8eef1273848309da62deb24160f1c14ef338f4
Reviewed-on: https://review.typo3.org/51883
Reviewed-by: Helmut Hummel <typo3@helhum.io>
Tested-by: Helmut Hummel <typo3@helhum.io>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
typo3/sysext/core/Classes/Core/Bootstrap.php
typo3/sysext/core/Configuration/DefaultConfiguration.php
typo3/sysext/core/Configuration/DefaultConfigurationDescription.php
typo3/sysext/core/Configuration/FactoryConfiguration.php
typo3/sysext/core/Documentation/Changelog/master/Breaking-80050-RemovedOptionCHashIncludePageIdFromCHashCalculation.rst [new file with mode: 0644]
typo3/sysext/frontend/Classes/Page/CacheHashCalculator.php
typo3/sysext/frontend/Tests/Unit/Page/CacheHashCalculatorTest.php
typo3/sysext/install/Classes/Service/SilentConfigurationUpgradeService.php
typo3/sysext/lang/Resources/Private/Language/locallang_core.xlf
typo3/sysext/reports/Classes/Report/Status/SecurityStatus.php
typo3/sysext/reports/Resources/Private/Language/locallang_reports.xlf