[!!!][TASK] EXT:form - Refactor fluid rendering 42/51442/13
authorRalf Zimmermann <ralf.zimmermann@tritum.de>
Thu, 26 Jan 2017 22:52:51 +0000 (23:52 +0100)
committerSusanne Moog <susanne.moog@typo3.org>
Thu, 2 Feb 2017 12:48:44 +0000 (13:48 +0100)
commit605b0c8d6a8975a8556bb05b7e915f5e2de43e75
tree1a29fbc59e2305738cb8a17bf6a81de38195a0c7
parent33adb38a07bc0a3d3836c3a25fa0a87b595c101d
[!!!][TASK] EXT:form - Refactor fluid rendering

This patch is a followup of issue #79439.

EXT:form uses "fluid" as the default rendering strategy.
Therefore, EXT:form has to work close with the concepts of fluid to
avoid current and future problems.
Until now, EXT:form tried to reuse a fluid view instance by
reconfiguring the instance on each nesting level, but fluid is not
intended for such a purpose.
Therefore, the templates have to be moved/ changed and some
configuration has to be changed.
The patch breaks EXT:form only for people who are using custom
configurations/ templates.

Resolves: #79464
Releases: master
Change-Id: I6346b888b47a52bcc995c7d4cd3acdc65a1396c8
Reviewed-on: https://review.typo3.org/51442
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Bjoern Jacob <bjoern.jacob@tritum.de>
Tested-by: Andreas Steiger <typo3@andreassteiger.de>
Tested-by: Tobi Kretschmann <tobi@tobishome.de>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
135 files changed:
typo3/sysext/core/Documentation/Changelog/master/Breaking-79464-ExtFormRefactorFluidRendering.rst [new file with mode: 0644]
typo3/sysext/form/Classes/Controller/FormEditorController.php
typo3/sysext/form/Classes/Domain/Finishers/EmailFinisher.php
typo3/sysext/form/Classes/Domain/Model/FormDefinition.php
typo3/sysext/form/Classes/Domain/Model/FormElements/AbstractSection.php
typo3/sysext/form/Classes/Domain/Model/FormElements/UnknownFormElement.php
typo3/sysext/form/Classes/Domain/Model/Renderable/AbstractRenderable.php
typo3/sysext/form/Classes/Domain/Model/Renderable/RenderableInterface.php
typo3/sysext/form/Classes/Domain/Model/Renderable/RootRenderableInterface.php
typo3/sysext/form/Classes/Domain/Renderer/FluidFormRenderer.php
typo3/sysext/form/Classes/Domain/Renderer/RendererInterface.php
typo3/sysext/form/Classes/Domain/Renderer/UnknownFormElementRenderer.php [deleted file]
typo3/sysext/form/Classes/Domain/Runtime/FormRuntime.php
typo3/sysext/form/Classes/Mvc/View/FormView.php [deleted file]
typo3/sysext/form/Classes/Mvc/View/TemplatePaths.php [deleted file]
typo3/sysext/form/Classes/ViewHelpers/Form/DatePickerViewHelper.php
typo3/sysext/form/Classes/ViewHelpers/Form/TimePickerViewHelper.php
typo3/sysext/form/Classes/ViewHelpers/FormViewHelper.php
typo3/sysext/form/Classes/ViewHelpers/PlainTextMailViewHelper.php
typo3/sysext/form/Classes/ViewHelpers/RenderAllFormValuesViewHelper.php
typo3/sysext/form/Classes/ViewHelpers/RenderRenderableViewHelper.php
typo3/sysext/form/Classes/ViewHelpers/TranslateElementPropertyViewHelper.php
typo3/sysext/form/Configuration/Yaml/BaseSetup.yaml
typo3/sysext/form/Configuration/Yaml/FormEditorSetup.yaml
typo3/sysext/form/Resources/Private/Backend/Layouts/FormEditor.html
typo3/sysext/form/Resources/Private/Backend/Partials/FormEditor/Inspector/CheckboxEditor.html [new file with mode: 0644]
typo3/sysext/form/Resources/Private/Backend/Partials/FormEditor/Inspector/CollectionElementHeaderEditor.html [new file with mode: 0644]
typo3/sysext/form/Resources/Private/Backend/Partials/FormEditor/Inspector/FinishersEditor.html [new file with mode: 0644]
typo3/sysext/form/Resources/Private/Backend/Partials/FormEditor/Inspector/FormElementHeaderEditor.html [new file with mode: 0644]
typo3/sysext/form/Resources/Private/Backend/Partials/FormEditor/Inspector/PropertyGridEditor.html [new file with mode: 0644]
typo3/sysext/form/Resources/Private/Backend/Partials/FormEditor/Inspector/RemoveElementEditor.html [new file with mode: 0644]
typo3/sysext/form/Resources/Private/Backend/Partials/FormEditor/Inspector/RequiredValidatorEditor.html [new file with mode: 0644]
typo3/sysext/form/Resources/Private/Backend/Partials/FormEditor/Inspector/SingleSelectEditor.html [new file with mode: 0644]
typo3/sysext/form/Resources/Private/Backend/Partials/FormEditor/Inspector/TextEditor.html [new file with mode: 0644]
typo3/sysext/form/Resources/Private/Backend/Partials/FormEditor/Inspector/TextareaEditor.html [new file with mode: 0644]
typo3/sysext/form/Resources/Private/Backend/Partials/FormEditor/Inspector/Typo3WinBrowserEditor.html [new file with mode: 0644]
typo3/sysext/form/Resources/Private/Backend/Partials/FormEditor/Inspector/ValidatorsEditor.html [new file with mode: 0644]
typo3/sysext/form/Resources/Private/Backend/Partials/FormEditor/Modals/InsertElements.html [new file with mode: 0644]
typo3/sysext/form/Resources/Private/Backend/Partials/FormEditor/Modals/InsertPages.html [new file with mode: 0644]
typo3/sysext/form/Resources/Private/Backend/Partials/FormEditor/Modals/ValidationErrors.html [new file with mode: 0644]
typo3/sysext/form/Resources/Private/Backend/Partials/FormEditor/Stage/ContentElement.html [new file with mode: 0644]
typo3/sysext/form/Resources/Private/Backend/Partials/FormEditor/Stage/Fieldset.html [new file with mode: 0644]
typo3/sysext/form/Resources/Private/Backend/Partials/FormEditor/Stage/Page.html [new file with mode: 0644]
typo3/sysext/form/Resources/Private/Backend/Partials/FormEditor/Stage/StaticText.html [new file with mode: 0644]
typo3/sysext/form/Resources/Private/Backend/Partials/FormEditor/Stage/SummaryPage.html [new file with mode: 0644]
typo3/sysext/form/Resources/Private/Backend/Partials/FormEditor/Stage/_ElementToolbar.html [new file with mode: 0644]
typo3/sysext/form/Resources/Private/Backend/Partials/FormEditor/Stage/_UnknownElement.html [new file with mode: 0644]
typo3/sysext/form/Resources/Private/Backend/Templates/FormEditor/InlineTemplates.html [new file with mode: 0644]
typo3/sysext/form/Resources/Private/Backend/Templates/FormEditor/Inspector/CheckboxEditor.html [deleted file]
typo3/sysext/form/Resources/Private/Backend/Templates/FormEditor/Inspector/CollectionElementHeaderEditor.html [deleted file]
typo3/sysext/form/Resources/Private/Backend/Templates/FormEditor/Inspector/FinishersEditor.html [deleted file]
typo3/sysext/form/Resources/Private/Backend/Templates/FormEditor/Inspector/FormElementHeaderEditor.html [deleted file]
typo3/sysext/form/Resources/Private/Backend/Templates/FormEditor/Inspector/PropertyGridEditor.html [deleted file]
typo3/sysext/form/Resources/Private/Backend/Templates/FormEditor/Inspector/RemoveElementEditor.html [deleted file]
typo3/sysext/form/Resources/Private/Backend/Templates/FormEditor/Inspector/RequiredValidatorEditor.html [deleted file]
typo3/sysext/form/Resources/Private/Backend/Templates/FormEditor/Inspector/SingleSelectEditor.html [deleted file]
typo3/sysext/form/Resources/Private/Backend/Templates/FormEditor/Inspector/TextEditor.html [deleted file]
typo3/sysext/form/Resources/Private/Backend/Templates/FormEditor/Inspector/TextareaEditor.html [deleted file]
typo3/sysext/form/Resources/Private/Backend/Templates/FormEditor/Inspector/Typo3WinBrowserEditor.html [deleted file]
typo3/sysext/form/Resources/Private/Backend/Templates/FormEditor/Inspector/ValidatorsEditor.html [deleted file]
typo3/sysext/form/Resources/Private/Backend/Templates/FormEditor/Modals/InsertElements.html [deleted file]
typo3/sysext/form/Resources/Private/Backend/Templates/FormEditor/Modals/InsertPages.html [deleted file]
typo3/sysext/form/Resources/Private/Backend/Templates/FormEditor/Modals/ValidationErrors.html [deleted file]
typo3/sysext/form/Resources/Private/Backend/Templates/FormEditor/Stage/AdvancedPassword.html [deleted file]
typo3/sysext/form/Resources/Private/Backend/Templates/FormEditor/Stage/Checkbox.html [deleted file]
typo3/sysext/form/Resources/Private/Backend/Templates/FormEditor/Stage/ContentElement.html [deleted file]
typo3/sysext/form/Resources/Private/Backend/Templates/FormEditor/Stage/DatePicker.html [deleted file]
typo3/sysext/form/Resources/Private/Backend/Templates/FormEditor/Stage/Fieldset.html [deleted file]
typo3/sysext/form/Resources/Private/Backend/Templates/FormEditor/Stage/FileUpload.html [deleted file]
typo3/sysext/form/Resources/Private/Backend/Templates/FormEditor/Stage/Hidden.html [deleted file]
typo3/sysext/form/Resources/Private/Backend/Templates/FormEditor/Stage/ImageUpload.html [deleted file]
typo3/sysext/form/Resources/Private/Backend/Templates/FormEditor/Stage/MultiCheckbox.html [deleted file]
typo3/sysext/form/Resources/Private/Backend/Templates/FormEditor/Stage/MultiSelect.html [deleted file]
typo3/sysext/form/Resources/Private/Backend/Templates/FormEditor/Stage/Page.html [deleted file]
typo3/sysext/form/Resources/Private/Backend/Templates/FormEditor/Stage/Password.html [deleted file]
typo3/sysext/form/Resources/Private/Backend/Templates/FormEditor/Stage/RadioButton.html [deleted file]
typo3/sysext/form/Resources/Private/Backend/Templates/FormEditor/Stage/SingleSelect.html [deleted file]
typo3/sysext/form/Resources/Private/Backend/Templates/FormEditor/Stage/StaticText.html [deleted file]
typo3/sysext/form/Resources/Private/Backend/Templates/FormEditor/Stage/SummaryPage.html [deleted file]
typo3/sysext/form/Resources/Private/Backend/Templates/FormEditor/Stage/Text.html [deleted file]
typo3/sysext/form/Resources/Private/Backend/Templates/FormEditor/Stage/Textarea.html [deleted file]
typo3/sysext/form/Resources/Private/Backend/Templates/FormEditor/Stage/_ElementToolbar.html [deleted file]
typo3/sysext/form/Resources/Private/Backend/Templates/FormEditor/Stage/_UnknownElement.html [deleted file]
typo3/sysext/form/Resources/Private/Frontend/Layouts/FormElements/Field.html [deleted file]
typo3/sysext/form/Resources/Private/Frontend/Partials/AdvancedPassword.html [new file with mode: 0644]
typo3/sysext/form/Resources/Private/Frontend/Partials/Checkbox.html [new file with mode: 0644]
typo3/sysext/form/Resources/Private/Frontend/Partials/ContentElement.html [new file with mode: 0644]
typo3/sysext/form/Resources/Private/Frontend/Partials/DatePicker.html [new file with mode: 0644]
typo3/sysext/form/Resources/Private/Frontend/Partials/Field/Field.html [new file with mode: 0644]
typo3/sysext/form/Resources/Private/Frontend/Partials/Field/Required.html [new file with mode: 0644]
typo3/sysext/form/Resources/Private/Frontend/Partials/Fieldset.html [new file with mode: 0644]
typo3/sysext/form/Resources/Private/Frontend/Partials/FileUpload.html [new file with mode: 0644]
typo3/sysext/form/Resources/Private/Frontend/Partials/Form/Navigation.html [new file with mode: 0644]
typo3/sysext/form/Resources/Private/Frontend/Partials/FormElements/Field/Required.html [deleted file]
typo3/sysext/form/Resources/Private/Frontend/Partials/FormElements/Form/Navigation.html [deleted file]
typo3/sysext/form/Resources/Private/Frontend/Partials/Hidden.html [new file with mode: 0644]
typo3/sysext/form/Resources/Private/Frontend/Partials/Honeypot.html [new file with mode: 0644]
typo3/sysext/form/Resources/Private/Frontend/Partials/ImageUpload.html [new file with mode: 0644]
typo3/sysext/form/Resources/Private/Frontend/Partials/MultiCheckbox.html [new file with mode: 0644]
typo3/sysext/form/Resources/Private/Frontend/Partials/MultiSelect.html [new file with mode: 0644]
typo3/sysext/form/Resources/Private/Frontend/Partials/Page.html [new file with mode: 0644]
typo3/sysext/form/Resources/Private/Frontend/Partials/Password.html [new file with mode: 0644]
typo3/sysext/form/Resources/Private/Frontend/Partials/RadioButton.html [new file with mode: 0644]
typo3/sysext/form/Resources/Private/Frontend/Partials/SingleSelect.html [new file with mode: 0644]
typo3/sysext/form/Resources/Private/Frontend/Partials/StaticText.html [new file with mode: 0644]
typo3/sysext/form/Resources/Private/Frontend/Partials/SummaryPage.html [new file with mode: 0644]
typo3/sysext/form/Resources/Private/Frontend/Partials/Text.html [new file with mode: 0644]
typo3/sysext/form/Resources/Private/Frontend/Partials/Textarea.html [new file with mode: 0644]
typo3/sysext/form/Resources/Private/Frontend/Partials/UnknownElement.html [new file with mode: 0644]
typo3/sysext/form/Resources/Private/Frontend/Templates/Finishers/Email/Html.html
typo3/sysext/form/Resources/Private/Frontend/Templates/Finishers/Email/Plaintext.html
typo3/sysext/form/Resources/Private/Frontend/Templates/Form.html [new file with mode: 0644]
typo3/sysext/form/Resources/Private/Frontend/Templates/FormElements/AdvancedPassword.html [deleted file]
typo3/sysext/form/Resources/Private/Frontend/Templates/FormElements/Checkbox.html [deleted file]
typo3/sysext/form/Resources/Private/Frontend/Templates/FormElements/ContentElement.html [deleted file]
typo3/sysext/form/Resources/Private/Frontend/Templates/FormElements/DatePicker.html [deleted file]
typo3/sysext/form/Resources/Private/Frontend/Templates/FormElements/Fieldset.html [deleted file]
typo3/sysext/form/Resources/Private/Frontend/Templates/FormElements/FileUpload.html [deleted file]
typo3/sysext/form/Resources/Private/Frontend/Templates/FormElements/Form.html [deleted file]
typo3/sysext/form/Resources/Private/Frontend/Templates/FormElements/Hidden.html [deleted file]
typo3/sysext/form/Resources/Private/Frontend/Templates/FormElements/Honeypot.html [deleted file]
typo3/sysext/form/Resources/Private/Frontend/Templates/FormElements/ImageUpload.html [deleted file]
typo3/sysext/form/Resources/Private/Frontend/Templates/FormElements/MultiCheckbox.html [deleted file]
typo3/sysext/form/Resources/Private/Frontend/Templates/FormElements/MultiSelect.html [deleted file]
typo3/sysext/form/Resources/Private/Frontend/Templates/FormElements/Page.html [deleted file]
typo3/sysext/form/Resources/Private/Frontend/Templates/FormElements/Password.html [deleted file]
typo3/sysext/form/Resources/Private/Frontend/Templates/FormElements/RadioButton.html [deleted file]
typo3/sysext/form/Resources/Private/Frontend/Templates/FormElements/SingleSelect.html [deleted file]
typo3/sysext/form/Resources/Private/Frontend/Templates/FormElements/StaticText.html [deleted file]
typo3/sysext/form/Resources/Private/Frontend/Templates/FormElements/SummaryPage.html [deleted file]
typo3/sysext/form/Resources/Private/Frontend/Templates/FormElements/Text.html [deleted file]
typo3/sysext/form/Resources/Private/Frontend/Templates/FormElements/Textarea.html [deleted file]
typo3/sysext/form/Tests/Unit/Controller/FormEditorControllerTest.php
typo3/sysext/form/Tests/Unit/Domain/FormElements/AbstractSectionTest.php [new file with mode: 0644]
typo3/sysext/form/Tests/Unit/Domain/Runtime/FormRuntimeTest.php [new file with mode: 0644]