[TASK] Deprecate GeneralUtility::_GETset() 44/58344/7
authorBenni Mack <benni@typo3.org>
Thu, 20 Sep 2018 06:44:41 +0000 (08:44 +0200)
committerAndreas Fernandez <a.fernandez@scripting-base.de>
Thu, 27 Sep 2018 12:24:37 +0000 (14:24 +0200)
commit443709b3849e178ff90a84199c51b239538ecac5
treee9a3b56bc6775c3d2294d6c9def5cb74548e48e4
parent417175663e7edb01bed342546c78e6c46d86137b
[TASK] Deprecate GeneralUtility::_GETset()

The functionality of _GETset() is really broken by design
when thinking about having a non-global state.

On top $TSFE->mergingWithGetVars(), which was mainly used
in RealURL, is deprecated, as this needs to go within a PSR-15
middlware (I actually did that in a fork already for realurl v1).

Resolves: #86389
Releases: master
Change-Id: I7081ed48131237f9d1b0da6a4ddf252a34a02072
Reviewed-on: https://review.typo3.org/58344
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
typo3/sysext/core/Classes/Utility/GeneralUtility.php
typo3/sysext/core/Documentation/Changelog/master/Deprecation-86389-GeneralUtility_GETsetAndTSFE-mergingWithGetVars.rst [new file with mode: 0644]
typo3/sysext/core/Tests/Unit/Utility/GeneralUtilityTest.php
typo3/sysext/core/Tests/UnitDeprecated/Utility/GeneralUtilityTest.php
typo3/sysext/extbase/Tests/Unit/Configuration/BackendConfigurationManagerTest.php
typo3/sysext/extbase/Tests/Unit/Mvc/Web/Routing/UriBuilderTest.php
typo3/sysext/frontend/Classes/Controller/TypoScriptFrontendController.php
typo3/sysext/install/Configuration/ExtensionScanner/Php/MethodCallMatcher.php
typo3/sysext/install/Configuration/ExtensionScanner/Php/MethodCallStaticMatcher.php