[TASK] Move preview setting evaluation in separate method 13/55913/2
authorBenni Mack <benni@typo3.org>
Tue, 27 Feb 2018 06:15:39 +0000 (07:15 +0100)
committerSusanne Moog <susanne.moog@typo3.org>
Wed, 28 Feb 2018 07:54:04 +0000 (08:54 +0100)
commit3eff062e9962bd1cdcef6773dd46a128a3aaa546
treed13da6d598385d4b36c56ba515f5d8dff713d5ef
parent733264c1960793232dae7855466750e9bead7a60
[TASK] Move preview setting evaluation in separate method

The TSFE method "determineId" is hard to read, mostly due to
the fact that it first evaluates preview settings from admin panel
or logged-in backend users, and then calls "fetch_the_id()" possibly
multiple times.

In order to increase readability, the preview settings evaluation
is moved into a custom protected method within TSFE.

Resolves: #84056
Releases: master
Change-Id: I9611801b77ab10f0e9407f2c558cbec1867cc560
Reviewed-on: https://review.typo3.org/55913
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
typo3/sysext/frontend/Classes/Controller/TypoScriptFrontendController.php