[TASK] Deprecate BackendUtility::getRecordsByField 78/51078/9
authorMorton Jonuschat <m.jonuschat@mojocode.de>
Fri, 30 Dec 2016 22:33:58 +0000 (14:33 -0800)
committerChristian Kuhn <lolli@schwarzbu.ch>
Fri, 24 Feb 2017 08:26:58 +0000 (09:26 +0100)
commit36e461d18deb4cb21cc60e679717bf3c559191cb
tree44b02ed0306e38813e1df3867e4dd1df0e6305b2
parentcce7d774d926027ed32148f3709a4cac211a2612
[TASK] Deprecate BackendUtility::getRecordsByField

Deprecate BackendUtility::getRecordsByField() as it has a flawed design
due to passing SQL fragments. This contradicts the goal of using named
parameters for all queries in the core and requires passing the original
QueryBuilder object in addition to the stringified constraint.

Replace all calls to the method with direct usage of the QueryBuilder and
deprecate the method.

Resolves: #79122
Releases: master
Change-Id: I8b040b98e20271aff84ef16fb89b59a406d54003
Reviewed-on: https://review.typo3.org/51078
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Tested-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
14 files changed:
typo3/sysext/backend/Classes/Controller/BackendController.php
typo3/sysext/backend/Classes/Domain/Repository/Localization/LocalizationRepository.php
typo3/sysext/backend/Classes/Utility/BackendUtility.php
typo3/sysext/backend/Classes/View/PageLayoutView.php
typo3/sysext/backend/Tests/Functional/Utility/BackendUtilityTest.php [new file with mode: 0644]
typo3/sysext/backend/Tests/Functional/Utility/Fixtures/sys_domain.xml [new file with mode: 0644]
typo3/sysext/core/Classes/Authentication/BackendUserAuthentication.php
typo3/sysext/core/Classes/DataHandling/DataHandler.php
typo3/sysext/core/Classes/Database/Query/QueryBuilder.php
typo3/sysext/core/Classes/Database/SoftReferenceIndex.php
typo3/sysext/core/Documentation/Changelog/master/Deprecation-79122-DeprecateBackendUtilitygetRecordsByField.rst [new file with mode: 0644]
typo3/sysext/recordlist/Classes/LinkHandler/PageLinkHandler.php
typo3/sysext/recycler/Classes/Domain/Model/DeletedRecords.php
typo3/sysext/workspaces/Classes/Service/WorkspaceService.php