[TASK] Remove usages of call_user_func() and call_user_func_array()
authorLarry Garfield <larry@garfieldtech.com>
Tue, 4 May 2021 17:03:19 +0000 (12:03 -0500)
committerBenni Mack <benni@typo3.org>
Fri, 7 May 2021 20:14:08 +0000 (22:14 +0200)
commit3456ae0a791f5369e3a6ff174a6477310ce5cde1
treefb0e672010c14ab5e3c7c75365c7c8bd12c40c8e
parent9fd59c5867d0bbf46ef2b36bb5a74b366e4fa300
[TASK] Remove usages of call_user_func() and call_user_func_array()

Using direct calls and variadics is slightly faster, and usually cleaner to read.

I left in the instant-call call_user_func() instances in the entry point files, as
that's only a single call and is arguably at least no worse than (function() {})().

Resolves: #94060
Releases: master
Change-Id: I95988feadf8522d8d936a273608e0ef2d5ce75b5
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69017
Tested-by: Benjamin Franzke <bfr@qbus.de>
Tested-by: core-ci <typo3@b13.com>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Benjamin Franzke <bfr@qbus.de>
Reviewed-by: crell <larry@garfieldtech.com>
Reviewed-by: Benni Mack <benni@typo3.org>
29 files changed:
typo3/sysext/backend/Classes/Http/RouteDispatcher.php
typo3/sysext/backend/Classes/Tree/Repository/PageTreeRepository.php
typo3/sysext/core/Classes/Configuration/FlexForm/FlexFormTools.php
typo3/sysext/core/Classes/Console/CommandApplication.php
typo3/sysext/core/Classes/DataHandling/DataHandler.php
typo3/sysext/core/Classes/DataHandling/SlugHelper.php
typo3/sysext/core/Classes/Database/RelationHandler.php
typo3/sysext/core/Classes/Http/AbstractApplication.php
typo3/sysext/core/Classes/Http/Dispatcher.php
typo3/sysext/core/Classes/Resource/Driver/LocalDriver.php
typo3/sysext/core/Classes/Resource/Filter/FileExtensionFilter.php
typo3/sysext/core/Classes/Resource/Filter/FileNameFilter.php
typo3/sysext/core/Classes/Resource/Search/Result/DriverFilteredSearchResult.php
typo3/sysext/core/Classes/Utility/ArrayUtility.php
typo3/sysext/core/Classes/Utility/GeneralUtility.php
typo3/sysext/core/Tests/Functional/Error/ErrorHandlerTest.php
typo3/sysext/core/Tests/Functional/IO/PharStreamWrapperInterceptorTest.php
typo3/sysext/core/Tests/Unit/FormProtection/FormProtectionFactoryTest.php
typo3/sysext/core/Tests/Unit/Log/LoggerTest.php
typo3/sysext/core/Tests/Unit/Resource/FileTest.php
typo3/sysext/extbase/Classes/Mvc/Controller/ActionController.php
typo3/sysext/extbase/Classes/Persistence/Generic/LazyLoadingProxy.php
typo3/sysext/extbase/Classes/Property/TypeConverter/ObjectConverter.php
typo3/sysext/extbase/Classes/SignalSlot/Dispatcher.php
typo3/sysext/extbase/Tests/Unit/Property/PropertyMappingConfigurationTest.php
typo3/sysext/filelist/Classes/FileFacade.php
typo3/sysext/frontend/Classes/ContentObject/ContentObjectRenderer.php
typo3/sysext/frontend/Tests/Functional/SiteHandling/AbstractTestCase.php
typo3/sysext/recycler/Classes/Controller/RecyclerModuleController.php