[BUGFIX] Handle empty string icon-overlay identifier 08/55808/2
authorRomain Canon <romain.hydrocanon@gmail.com>
Sat, 23 Sep 2017 13:07:02 +0000 (15:07 +0200)
committerFrank Naegler <frank.naegler@typo3.org>
Mon, 19 Feb 2018 21:41:35 +0000 (22:41 +0100)
commit2d61aac03aa0e3172ec118fc779bfae09ecadc49
treeb85700a9d2f90e5a6849676daa63343ba039ed9e
parenta5bb019c53f5d92608bbab22f61deed2cbfd9c6e
[BUGFIX] Handle empty string icon-overlay identifier

An overlay identifier can be an empty string, for instance when the icon API is
called with the Fluid icon view helper:

```
<core:icon identifier="tx-my-icon"
           overlay="{f:if(condition: myCondition, then: 'my-overlay-icon')}" />
```

In the example below, if the condition `myCondition` is `false`, an empty string
is used for the overlay parameter.

---

Previously, an empty string as overlay identifier would lead to the basic "not
found icon" being used as overlay.

With this commit, the behaviour for an empty string will now be the same as when
 `null` is used.

---

Resolves: #82547
Releases: master, 8.7
Change-Id: I6fb8207f302873e0188d71a210485bbf8565eff9
Reviewed-on: https://review.typo3.org/55808
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
typo3/sysext/core/Classes/Imaging/IconFactory.php