[BUGFIX] Fix relogin with popup 78/54278/14
authorBenni Mack <benni@typo3.org>
Thu, 10 May 2018 13:46:20 +0000 (15:46 +0200)
committerSusanne Moog <susanne.moog@typo3.org>
Sat, 12 May 2018 10:58:12 +0000 (12:58 +0200)
commit26894af66b8dbecac263e419a7d47f7b66c03607
tree71a7e6d2c927876760be4e5bc49a5290c08b9dc9
parent02aecbf9f55bceff364b3e41676d92b83c9e9e13
[BUGFIX] Fix relogin with popup

The re-login popup in BE has some issues:
- An empty frameset is loaded within the popup which is not needed
and makes the code harder to understand (parent.window.opener)
- The popup always shows the logout form, although the relogin should
show the login credentials form (because the view did not get the memo)
- Login.html should not use "../../../../" for referencing
the form

The LoginFrameset controller thus is not used (will be deprecated
in a separate patch).

This patch moves the logic into the LoginController.

Resolves: #83430
Releases: master
Change-Id: If872baf26297c8b75b786c2d8881802b05b1e41a
Reviewed-on: https://review.typo3.org/54278
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
typo3/sysext/backend/Classes/Controller/LoginController.php
typo3/sysext/backend/Classes/Middleware/BackendUserAuthenticator.php
typo3/sysext/backend/Configuration/Backend/Routes.php
typo3/sysext/backend/Resources/Private/Layouts/Login.html
typo3/sysext/backend/Tests/Unit/Controller/LoginControllerTest.php