[TASK] Install Tool: Optimize permission checking and fixing 16/25416/10
authorErnesto Baschny <ernst@cron-it.de>
Thu, 14 Nov 2013 12:44:02 +0000 (13:44 +0100)
committerErnesto Baschny <ernst@cron-it.de>
Sat, 15 Mar 2014 21:06:30 +0000 (22:06 +0100)
commit18a8f44414593cccd3469ff63afe6d90ebd7cab1
treea7b8a34cd98e37105f219263c3225b35e0bcbeec
parent7d80f335cd8c93d86845a754177c5f0a71847f21
[TASK] Install Tool: Optimize permission checking and fixing

* Adjust default permissions back to "world readable" (775/664)
* Do not attempt to fix permissions on an existing folder structure
* Streamline the separation of Notices, Warnings and Errors
* Cosmetical optimizations in the "Folder Structure" item
* Also report if the default permissions are too insecure (i.e.
  world writeable / readable).

Note that the new defaults (775/664) are set to make the system work
by default on almost most scenarios, but the recommended secure setup
is still 770/660. This is on purpose to make the administrator aware
of it but will require manual intervention (i.e. "thinking") if this
setup will work or not (we cannot detect that automatically).

Resolves: #52668
Releases: 6.2
Change-Id: I77c72617fa58fd808ebc5fd818e94b48c2644102
Reviewed-on: https://review.typo3.org/25416
Reviewed-by: Christian Kuhn
Reviewed-by: Wouter Wolters
Reviewed-by: Stefan Neufeind
Reviewed-by: Philipp Gampe
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Ernesto Baschny
Tested-by: Ernesto Baschny
18 files changed:
typo3/sysext/core/Configuration/DefaultConfiguration.php
typo3/sysext/install/Classes/Controller/Action/AbstractAction.php
typo3/sysext/install/Classes/Controller/Action/Tool/FolderStructure.php
typo3/sysext/install/Classes/FolderStructure/AbstractNode.php
typo3/sysext/install/Classes/FolderStructure/DefaultFactory.php
typo3/sysext/install/Classes/FolderStructure/DefaultPermissionsCheck.php [new file with mode: 0644]
typo3/sysext/install/Classes/FolderStructure/DirectoryNode.php
typo3/sysext/install/Classes/FolderStructure/FileNode.php
typo3/sysext/install/Classes/FolderStructure/LinkNode.php
typo3/sysext/install/Classes/FolderStructure/NodeInterface.php
typo3/sysext/install/Classes/FolderStructure/RootNode.php
typo3/sysext/install/Resources/Private/Templates/Action/Tool/FolderStructure.html
typo3/sysext/install/Resources/Public/Stylesheets/Action/Common/Install.css
typo3/sysext/install/Tests/Unit/FolderStructure/AbstractNodeTest.php
typo3/sysext/install/Tests/Unit/FolderStructure/DirectoryNodeTest.php
typo3/sysext/install/Tests/Unit/FolderStructure/FileNodeTest.php
typo3/sysext/install/Tests/Unit/FolderStructure/LinkNodeTest.php
typo3/sysext/install/Tests/Unit/FolderStructure/RootNodeTest.php