[!!!][TASK] Extension manager: Drop "Download SQL Dump" 64/53764/3
authorChristian Kuhn <lolli@schwarzbu.ch>
Mon, 21 Aug 2017 15:05:08 +0000 (17:05 +0200)
committerBenni Mack <benni@typo3.org>
Tue, 22 Aug 2017 19:10:49 +0000 (21:10 +0200)
commit15819601d9d0ce01de03191a0e4205d10c5087b4
tree7fcf4a18235111221979020c8530ddeea9409497
parenta6ec631560a55633ae8dacaaf70d4674bd2b96e6
[!!!][TASK] Extension manager: Drop "Download SQL Dump"

The em in "Installed Extensions" has a button "Download SQL Dump"
for all extensions that provide ext_tables.sql. On click, an sql
dump file is sent.

This feature is severely flawed:
* Dumps of extensions that add fields to existing tables contain
  a 'drop table' of these tables, the 'import into' statements are
  broken and only (try to) add these fields again. This easily
  leads to hazard in DB if importing such a dump.
* There are no charset specs and other meta data whatsoever in the dump.
* The dump is not dbal compatible, field definitions and imports
  are incomplete.

We assume nobody really used this feature in a sane way, even at
this prominent position in em. The lack of bug reports to this
broken feature and the fact there have been zero changes in this
area since main em refactoring years ago support this view.

There are way better options to retrieve proper data specifications:
* The list module has a csv export
* Ext:impexp supports export and import in a much better way
  including proper relation handling and other options.
* Low level db exports and backups should be done on cli or
  with more powerful guis like phpmyadmin or other db engine
  specific tools.

The feature is dropped without substitution.

The v8 backport of this patch will just remove the button from
the em list view, but keep all code.

Change-Id: Ia027e7498c5464af04c49675987a696ee3a06070
Resolves: #82148
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/53764
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
14 files changed:
typo3/sysext/core/Documentation/Changelog/master/Breaking-82148-DownloadSQLDumpDroppedInEM.rst [new file with mode: 0644]
typo3/sysext/extensionmanager/Classes/Controller/ActionController.php
typo3/sysext/extensionmanager/Classes/Utility/DatabaseUtility.php [deleted file]
typo3/sysext/extensionmanager/Classes/Utility/FileHandlingUtility.php
typo3/sysext/extensionmanager/Classes/Utility/InstallUtility.php
typo3/sysext/extensionmanager/Classes/ViewHelpers/DownloadExtensionDataViewHelper.php [deleted file]
typo3/sysext/extensionmanager/Classes/ViewHelpers/ReloadSqlDataViewHelper.php
typo3/sysext/extensionmanager/Resources/Private/Templates/List/Index.html
typo3/sysext/extensionmanager/ext_tables.php
typo3/sysext/install/Classes/Service/SqlSchemaMigrationService.php [deleted file]
typo3/sysext/install/Configuration/ExtensionScanner/Php/ClassNameMatcher.php
typo3/sysext/install/Configuration/ExtensionScanner/Php/MethodCallMatcher.php
typo3/sysext/install/Tests/Functional/SqlSchemaMigrationServiceTest.php [deleted file]
typo3/sysext/install/Tests/Unit/Service/SqlSchemaMigrationServiceTest.php [deleted file]