[BUGFIX] Remove wrong usage of PageRepository->error_getRootLine_failPid 21/52621/4
authorBenni Mack <benni@typo3.org>
Wed, 26 Apr 2017 19:38:35 +0000 (21:38 +0200)
committerGeorg Ringer <georg.ringer@gmail.com>
Thu, 27 Apr 2017 11:34:17 +0000 (13:34 +0200)
commit10ff1288a56923b61dbc7b811c93d05f8bc84524
tree449f2fb54c3657b06e9e5df65dd3832403cfe916
parent407f8c4986deeb20a01a20d91512278cd04f718e
[BUGFIX] Remove wrong usage of PageRepository->error_getRootLine_failPid

The TypoScript frontend calls TSFE->sys_page->getRootline() which fills
the public property "error_getRootLine_failPid" when the third parameter
is set. Otherwise it throws an exception.

Setting this option was actually removed in TYPO3 when the RootlineUtility
was introduced, making the third parameter very non-useful, as it does not
throw exceptions but instead writing some weird values in the error_getRootLine
property.

It also goes back to the case where branch versioning was still supported.

In case of regular frontend requests there is a lot of dead code now because
of always-false checks on $TSFE->sys_page->error_getRootLine_failPid == -1.

Resolves: #81027
Releases: master, 8.7
Change-Id: I141f145c1855f09c33f003422c8e34653bf7f951
Reviewed-on: https://review.typo3.org/52621
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
typo3/sysext/frontend/Classes/Controller/TypoScriptFrontendController.php