[CLEANUP] Ensure variables initalized and fix code smell 42/51742/3
authorSascha Egerer <sascha@sascha-egerer.de>
Sat, 18 Feb 2017 15:58:33 +0000 (16:58 +0100)
committerChristian Kuhn <lolli@schwarzbu.ch>
Thu, 23 Feb 2017 14:02:43 +0000 (15:02 +0100)
commit00b97d7ff9b2ac3dd5afe1149ae10a4c65ab9744
tree3ab1146fb44149cf02f54433a8b759aeebf8d132
parent09e2dd1fb528f8b4330e51851151722a0743f0fb
[CLEANUP] Ensure variables initalized and fix code smell

* Ensure that variables are correctly initalized.
* Fix some php docs.
* Initalizes for loop iterator variables before the loop if they are
  also used after the for loop is finished.
* Remove superfluous function arguments.

Resolves: #79892
Releases: master
Change-Id: I75109b2914f2b05806a303837b7aad79be8e3707
Reviewed-on: https://review.typo3.org/51742
Reviewed-by: Thomas Hohn <thomas@hohn.dk>
Tested-by: Thomas Hohn <thomas@hohn.dk>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christer V <cvi@systime.dk>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
23 files changed:
typo3/sysext/core/Classes/Charset/CharsetConverter.php
typo3/sysext/core/Classes/Configuration/FlexForm/FlexFormTools.php
typo3/sysext/core/Classes/Configuration/TypoScript/ConditionMatching/AbstractConditionMatcher.php
typo3/sysext/core/Classes/Controller/CommandLineController.php
typo3/sysext/core/Classes/DataHandling/DataHandler.php
typo3/sysext/core/Classes/Database/QueryGenerator.php
typo3/sysext/core/Classes/Database/QueryView.php
typo3/sysext/core/Classes/ExtDirect/ExtDirectRouter.php
typo3/sysext/core/Classes/FrontendEditing/FrontendEditingController.php
typo3/sysext/core/Classes/Html/RteHtmlParser.php
typo3/sysext/core/Classes/Http/Response.php
typo3/sysext/core/Classes/Localization/LanguageStore.php
typo3/sysext/core/Classes/Localization/Parser/LocallangXmlParser.php
typo3/sysext/core/Classes/Package/MetaData/PackageConstraint.php
typo3/sysext/core/Classes/Service/DependencyOrderingService.php
typo3/sysext/core/Classes/TimeTracker/TimeTracker.php
typo3/sysext/core/Classes/TypoScript/ConfigurationForm.php
typo3/sysext/core/Classes/Utility/CommandUtility.php
typo3/sysext/core/Classes/Utility/File/ExtendedFileUtility.php
typo3/sysext/core/Classes/Utility/GeneralUtility.php
typo3/sysext/core/Tests/Unit/Http/UploadedFileTest.php
typo3/sysext/core/Tests/Unit/Resource/FolderTest.php
typo3/sysext/core/Tests/Unit/Utility/ArrayUtilityTest.php