[BUGFIX] Fix tag consistency of FSC DropIn partials
[Packages/TYPO3.CMS.git] / typo3 / sysext / extbase / Tests / Unit / Mvc / Controller / AbstractControllerTest.php
index 840ca19..f9eb282 100644 (file)
@@ -14,133 +14,114 @@ namespace TYPO3\CMS\Extbase\Tests\Unit\Mvc\Controller;
  * The TYPO3 project - inspiring people to share!
  */
 
+use TYPO3\TestingFramework\Core\Unit\UnitTestCase;
+
 /**
  * Test case
  */
-class AbstractControllerTest extends \TYPO3\CMS\Core\Tests\UnitTestCase {
-
-       /**
-        * @test
-        */
-       public function constructResolvesExtensionnameFromOldStyle() {
-               $className = uniqid('Tx_Extbase_Tests_Fixtures_Controller');
-               eval('class ' . $className . ' extends \\' . \TYPO3\CMS\Extbase\Mvc\Controller\AbstractController::class . ' { function getExtensionName() { return $this->extensionName; } }');
-               $mockController = new $className();
-               $expectedResult = 'Extbase';
-               $actualResult = $mockController->getExtensionName();
-               $this->assertEquals($expectedResult, $actualResult);
-       }
-
-       /**
-        * @test
-        */
-       public function constructResolvesExtensionnameFromNamespaced() {
-               $className = uniqid('DummyController');
-               eval('namespace ' . __NAMESPACE__ . '; class ' . $className . ' extends \\' . \TYPO3\CMS\Extbase\Mvc\Controller\AbstractController::class . ' { function getExtensionName() { return $this->extensionName; } }');
-               $classNameNamespaced = __NAMESPACE__ . '\\' . $className;
-               $mockController = new $classNameNamespaced();
-               $expectedResult = 'Extbase';
-               $actualResult = $mockController->getExtensionName();
-               $this->assertEquals($expectedResult, $actualResult);
-       }
-
-       /**
-        * @return array
-        */
-       public function addFlashMessageDataProvider() {
-               return array(
-                       array(
-                               new \TYPO3\CMS\Core\Messaging\FlashMessage('Simple Message'),
-                               'Simple Message',
-                               '',
-                               \TYPO3\CMS\Core\Messaging\FlashMessage::OK,
-                               FALSE
-                       ),
-                       array(
-                               new \TYPO3\CMS\Core\Messaging\FlashMessage('Some OK', 'Message Title', \TYPO3\CMS\Core\Messaging\FlashMessage::OK, TRUE),
-                               'Some OK',
-                               'Message Title',
-                               \TYPO3\CMS\Core\Messaging\FlashMessage::OK,
-                               TRUE
-                       ),
-                       array(
-                               new \TYPO3\CMS\Core\Messaging\FlashMessage('Some Info', 'Message Title', \TYPO3\CMS\Core\Messaging\FlashMessage::INFO, TRUE),
-                               'Some Info',
-                               'Message Title',
-                               \TYPO3\CMS\Core\Messaging\FlashMessage::INFO,
-                               TRUE
-                       ),
-                       array(
-                               new \TYPO3\CMS\Core\Messaging\FlashMessage('Some Notice', 'Message Title', \TYPO3\CMS\Core\Messaging\FlashMessage::NOTICE, TRUE),
-                               'Some Notice',
-                               'Message Title',
-                               \TYPO3\CMS\Core\Messaging\FlashMessage::NOTICE,
-                               TRUE
-                       ),
+class AbstractControllerTest extends UnitTestCase
+{
+    /**
+     * @return array
+     */
+    public function addFlashMessageDataProvider()
+    {
+        return [
+            [
+                new \TYPO3\CMS\Core\Messaging\FlashMessage('Simple Message'),
+                'Simple Message',
+                '',
+                \TYPO3\CMS\Core\Messaging\FlashMessage::OK,
+                false
+            ],
+            [
+                new \TYPO3\CMS\Core\Messaging\FlashMessage('Some OK', 'Message Title', \TYPO3\CMS\Core\Messaging\FlashMessage::OK, true),
+                'Some OK',
+                'Message Title',
+                \TYPO3\CMS\Core\Messaging\FlashMessage::OK,
+                true
+            ],
+            [
+                new \TYPO3\CMS\Core\Messaging\FlashMessage('Some Info', 'Message Title', \TYPO3\CMS\Core\Messaging\FlashMessage::INFO, true),
+                'Some Info',
+                'Message Title',
+                \TYPO3\CMS\Core\Messaging\FlashMessage::INFO,
+                true
+            ],
+            [
+                new \TYPO3\CMS\Core\Messaging\FlashMessage('Some Notice', 'Message Title', \TYPO3\CMS\Core\Messaging\FlashMessage::NOTICE, true),
+                'Some Notice',
+                'Message Title',
+                \TYPO3\CMS\Core\Messaging\FlashMessage::NOTICE,
+                true
+            ],
 
-                       array(
-                               new \TYPO3\CMS\Core\Messaging\FlashMessage('Some Warning', 'Message Title', \TYPO3\CMS\Core\Messaging\FlashMessage::WARNING, TRUE),
-                               'Some Warning',
-                               'Message Title',
-                               \TYPO3\CMS\Core\Messaging\FlashMessage::WARNING,
-                               TRUE
-                       ),
-                       array(
-                               new \TYPO3\CMS\Core\Messaging\FlashMessage('Some Error', 'Message Title', \TYPO3\CMS\Core\Messaging\FlashMessage::ERROR, TRUE),
-                               'Some Error',
-                               'Message Title',
-                               \TYPO3\CMS\Core\Messaging\FlashMessage::ERROR,
-                               TRUE
-                       )
-               );
-       }
+            [
+                new \TYPO3\CMS\Core\Messaging\FlashMessage('Some Warning', 'Message Title', \TYPO3\CMS\Core\Messaging\FlashMessage::WARNING, true),
+                'Some Warning',
+                'Message Title',
+                \TYPO3\CMS\Core\Messaging\FlashMessage::WARNING,
+                true
+            ],
+            [
+                new \TYPO3\CMS\Core\Messaging\FlashMessage('Some Error', 'Message Title', \TYPO3\CMS\Core\Messaging\FlashMessage::ERROR, true),
+                'Some Error',
+                'Message Title',
+                \TYPO3\CMS\Core\Messaging\FlashMessage::ERROR,
+                true
+            ]
+        ];
+    }
 
-       /**
-        * @test
-        * @dataProvider addFlashMessageDataProvider
-        */
-       public function addFlashMessageAddsFlashMessageObjectToFlashMessageQueue($expectedMessage, $messageBody, $messageTitle = '', $severity = \TYPO3\CMS\Core\Messaging\FlashMessage::OK, $storeInSession = TRUE) {
-               $flashMessageQueue = $this->getMock(
-                       \TYPO3\CMS\Core\Messaging\FlashMessageQueue::class,
-                       array('enqueue'),
-                       array(uniqid('identifier_', TRUE))
-               );
-               $flashMessageQueue->expects($this->once())->method('enqueue')->with($this->equalTo($expectedMessage));
+    /**
+     * @test
+     * @dataProvider addFlashMessageDataProvider
+     */
+    public function addFlashMessageAddsFlashMessageObjectToFlashMessageQueue($expectedMessage, $messageBody, $messageTitle = '', $severity = \TYPO3\CMS\Core\Messaging\FlashMessage::OK, $storeInSession = true)
+    {
+        $flashMessageQueue = $this->getMockBuilder(\TYPO3\CMS\Core\Messaging\FlashMessageQueue::class)
+            ->setMethods(['enqueue'])
+            ->setConstructorArgs([$this->getUniqueId('identifier_')])
+            ->getMock();
 
-               $controllerContext = $this->getMock(
-                       \TYPO3\CMS\Extbase\Mvc\Controller\ControllerContext::class,
-                       array('getFlashMessageQueue')
-               );
-               $controllerContext->expects($this->once())->method('getFlashMessageQueue')->will($this->returnValue($flashMessageQueue));
+        $flashMessageQueue->expects($this->once())->method('enqueue')->with($this->equalTo($expectedMessage));
 
-               $controller = $this->getMockForAbstractClass(\TYPO3\CMS\Extbase\Mvc\Controller\AbstractController::class,
-                       array(),
-                       '',
-                       FALSE,
-                       TRUE,
-                       TRUE,
-                       array('dummy')
-               );
-               $this->inject($controller, 'controllerContext', $controllerContext);
+        $controllerContext = $this->getMockBuilder(\TYPO3\CMS\Extbase\Mvc\Controller\ControllerContext::class)
+            ->setMethods(['getFlashMessageQueue'])
+            ->getMock();
+        $controllerContext->expects($this->once())->method('getFlashMessageQueue')->will($this->returnValue($flashMessageQueue));
 
-               $controller->addFlashMessage($messageBody, $messageTitle, $severity, $storeInSession);
-       }
+        $controller = $this->getMockForAbstractClass(
+            \TYPO3\CMS\Extbase\Mvc\Controller\AbstractController::class,
+            [],
+            '',
+            false,
+            true,
+            true,
+            ['dummy']
+        );
+        $this->inject($controller, 'controllerContext', $controllerContext);
 
-       /**
-        * @test
-        * @expectedException \InvalidArgumentException
-        */
-       public function addFlashMessageThrowsExceptionOnInvalidMessageBody() {
-               $controller = $this->getMockForAbstractClass(\TYPO3\CMS\Extbase\Mvc\Controller\AbstractController::class,
-                       array(),
-                       '',
-                       FALSE,
-                       TRUE,
-                       TRUE,
-                       array('dummy')
-               );
+        $controller->addFlashMessage($messageBody, $messageTitle, $severity, $storeInSession);
+    }
 
-               $controller->addFlashMessage(new \stdClass());
-       }
+    /**
+     * @test
+     */
+    public function addFlashMessageThrowsExceptionOnInvalidMessageBody()
+    {
+        $this->expectException(\InvalidArgumentException::class);
+        $this->expectExceptionCode(1243258395);
+        $controller = $this->getMockForAbstractClass(
+            \TYPO3\CMS\Extbase\Mvc\Controller\AbstractController::class,
+            [],
+            '',
+            false,
+            true,
+            true,
+            ['dummy']
+        );
 
+        $controller->addFlashMessage(new \stdClass());
+    }
 }