[TASK] Clean up FrontendEditing Controller 25/57925/2
authorBenni Mack <benni@typo3.org>
Wed, 15 Aug 2018 20:19:07 +0000 (22:19 +0200)
committerAndreas Fernandez <a.fernandez@scripting-base.de>
Thu, 16 Aug 2018 14:21:46 +0000 (16:21 +0200)
commitb364d86a3aa16301c215fc088ae31e7c97ed976e
tree0b7a692b4f8b2cfaaf7d1ec32d5f077b495bc416
parent20b51f8861ea6be373955ee83b7c04b7a2fd07fa
[TASK] Clean up FrontendEditing Controller

The FrontendEditingController class in EXT:core does two things:
- persisting incoming GET/POST requests (actually only when EXT:feedit is installed)
- rendering editIcons and editIconPanel

In order to separate these concerns, the first patch extracts some minor functionality into
EXT:feedit, and cleans up code which should have been done long ago.

The next iteration will be to deprecate unused methods and properties, and to move
FrontendEditingController into EXT:feedit, however, using an Interface to
render editIcons and editPanels instead.

Resolves: #85869
Releases: master
Change-Id: I78ed1da9e619099dc56b970961c90c34f8dff1e4
Reviewed-on: https://review.typo3.org/57925
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Jörg Bösche <typo3@joergboesche.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
typo3/sysext/core/Classes/FrontendEditing/FrontendEditingController.php
typo3/sysext/feedit/Classes/Middleware/FrontendEditInitiator.php