[TASK] Install tool: Use ext:core messaging 35/53835/12
authorChristian Kuhn <lolli@schwarzbu.ch>
Wed, 30 Aug 2017 10:39:07 +0000 (12:39 +0200)
committerBenni Mack <benni@typo3.org>
Thu, 31 Aug 2017 15:27:50 +0000 (17:27 +0200)
commitaed46d2af8a98e1c6fffb3d5ee170a33ecc0a9f0
tree503b4716d93bd20223b48e8fb2fb0649fd2d56ef
parentc7cd254c70f9f56aac48d82fc33dfc286b8e9d34
[TASK] Install tool: Use ext:core messaging

The install tool brought its own "status message" class
structure since the 6.2 refactoring. This is used at many
places in the install tool for message handling.

The core has a very similar class construct "Messaging"
with only little dependencies, too. To simplify a later
separation of 'install tool' and 'installer' the internal
status message class structure is removed and transitioned
to the core Messaging structure. to get rid of just
another special thing the install tool does.

The ext:core FlashMessage and FlashMessageQueue now both
implement the \JsonSerialize interface. This allows direct
json_encode() calls on these objects, helpful for instance
for ajax responses.

In ext:install "Environment checks" suhosin specific checks
have been removed since the project is dead and only has a
pre-alpha php 7.0 fork, so probably nobody is using
that with the given core PHP constraints anymore.

Change-Id: Ifecd3cd4889d8db5aaf3e87f317c98be706ae82b
Resolves: #82257
Releases: master
Reviewed-on: https://review.typo3.org/53835
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
85 files changed:
typo3/sysext/core/Classes/Messaging/AbstractMessage.php
typo3/sysext/core/Classes/Messaging/FlashMessageQueue.php
typo3/sysext/core/Tests/Unit/FormProtection/FormProtectionFactoryTest.php
typo3/sysext/core/Tests/Unit/Messaging/FlashMessageQueueTest.php [new file with mode: 0644]
typo3/sysext/core/Tests/Unit/Messaging/FlashMessageTest.php [new file with mode: 0644]
typo3/sysext/install/Classes/Controller/AbstractController.php
typo3/sysext/install/Classes/Controller/Action/Ajax/ChangeInstallToolPassword.php
typo3/sysext/install/Classes/Controller/Action/Ajax/ClearAllCache.php
typo3/sysext/install/Classes/Controller/Action/Ajax/ClearTablesClear.php
typo3/sysext/install/Classes/Controller/Action/Ajax/ClearTypo3tempFiles.php
typo3/sysext/install/Classes/Controller/Action/Ajax/CoreUpdateAbstract.php
typo3/sysext/install/Classes/Controller/Action/Ajax/CoreUpdateIsUpdateAvailable.php
typo3/sysext/install/Classes/Controller/Action/Ajax/CreateAdmin.php
typo3/sysext/install/Classes/Controller/Action/Ajax/DatabaseAnalyzerAnalyze.php
typo3/sysext/install/Classes/Controller/Action/Ajax/DatabaseAnalyzerExecute.php
typo3/sysext/install/Classes/Controller/Action/Ajax/DumpAutoload.php
typo3/sysext/install/Classes/Controller/Action/Ajax/EnvironmentCheckGetStatus.php
typo3/sysext/install/Classes/Controller/Action/Ajax/FolderStructureGetStatus.php
typo3/sysext/install/Classes/Controller/Action/Ajax/ImageProcessing.php
typo3/sysext/install/Classes/Controller/Action/Ajax/LocalConfigurationWrite.php
typo3/sysext/install/Classes/Controller/Action/Ajax/MailTest.php
typo3/sysext/install/Classes/Controller/Action/Ajax/PresetActivate.php
typo3/sysext/install/Classes/Controller/Action/Ajax/ResetBackendUserUc.php
typo3/sysext/install/Classes/Controller/Action/Ajax/TcaExtTablesCheck.php
typo3/sysext/install/Classes/Controller/Action/Ajax/TcaMigrationsCheck.php
typo3/sysext/install/Classes/Controller/Action/Ajax/UninstallExtension.php
typo3/sysext/install/Classes/Controller/Action/Ajax/UpgradeWizardsBlockingDatabaseCharsetFix.php
typo3/sysext/install/Classes/Controller/Action/Ajax/UpgradeWizardsBlockingDatabaseExecute.php
typo3/sysext/install/Classes/Controller/Action/Ajax/UpgradeWizardsDoneUpgrades.php
typo3/sysext/install/Classes/Controller/Action/Ajax/UpgradeWizardsInput.php
typo3/sysext/install/Classes/Controller/Action/Ajax/UpgradeWizardsList.php
typo3/sysext/install/Classes/Controller/Action/Ajax/UpgradeWizardsMarkUndone.php
typo3/sysext/install/Classes/Controller/Action/Ajax/UpgradeWizardsSilentUpgrades.php
typo3/sysext/install/Classes/Controller/Action/Common/InstallToolDisabledAction.php
typo3/sysext/install/Classes/Controller/Action/Step/DatabaseConnect.php
typo3/sysext/install/Classes/Controller/Action/Step/DatabaseData.php
typo3/sysext/install/Classes/Controller/Action/Step/DatabaseSelect.php
typo3/sysext/install/Classes/Controller/Action/Step/DefaultConfiguration.php
typo3/sysext/install/Classes/Controller/Action/Step/EnvironmentAndFolders.php
typo3/sysext/install/Classes/Controller/Action/Step/StepInterface.php
typo3/sysext/install/Classes/Exception/AuthenticationRequiredException.php
typo3/sysext/install/Classes/FolderStructure/AbstractNode.php
typo3/sysext/install/Classes/FolderStructure/DefaultPermissionsCheck.php
typo3/sysext/install/Classes/FolderStructure/DirectoryNode.php
typo3/sysext/install/Classes/FolderStructure/FileNode.php
typo3/sysext/install/Classes/FolderStructure/LinkNode.php
typo3/sysext/install/Classes/FolderStructure/NodeInterface.php
typo3/sysext/install/Classes/FolderStructure/RootNode.php
typo3/sysext/install/Classes/FolderStructure/StructureFacade.php
typo3/sysext/install/Classes/FolderStructure/StructureFacadeInterface.php
typo3/sysext/install/Classes/Http/RecoveryRequestHandler.php
typo3/sysext/install/Classes/Http/RequestHandler.php
typo3/sysext/install/Classes/Report/EnvironmentStatusReport.php
typo3/sysext/install/Classes/Service/CoreUpdateService.php
typo3/sysext/install/Classes/Service/LocalConfigurationValueService.php
typo3/sysext/install/Classes/Service/SessionService.php
typo3/sysext/install/Classes/Service/UpgradeWizardsService.php
typo3/sysext/install/Classes/Status/AbstractStatus.php [deleted file]
typo3/sysext/install/Classes/Status/AlertStatus.php [deleted file]
typo3/sysext/install/Classes/Status/ErrorStatus.php [deleted file]
typo3/sysext/install/Classes/Status/Exception.php [deleted file]
typo3/sysext/install/Classes/Status/InfoStatus.php [deleted file]
typo3/sysext/install/Classes/Status/LoadingStatus.php [deleted file]
typo3/sysext/install/Classes/Status/NoticeStatus.php [deleted file]
typo3/sysext/install/Classes/Status/OkStatus.php [deleted file]
typo3/sysext/install/Classes/Status/StatusInterface.php [deleted file]
typo3/sysext/install/Classes/Status/StatusUtility.php [deleted file]
typo3/sysext/install/Classes/Status/WarningStatus.php [deleted file]
typo3/sysext/install/Classes/SystemEnvironment/Check.php
typo3/sysext/install/Classes/SystemEnvironment/CheckInterface.php
typo3/sysext/install/Classes/SystemEnvironment/DatabaseCheck.php
typo3/sysext/install/Classes/SystemEnvironment/DatabasePlatform/MySqlCheck.php
typo3/sysext/install/Classes/SystemEnvironment/DatabasePlatform/PostgreSqlCheck.php
typo3/sysext/install/Classes/SystemEnvironment/SetupCheck.php
typo3/sysext/install/Resources/Private/Partials/Action/Common/StatusMessage.html
typo3/sysext/install/Tests/Unit/FolderStructure/AbstractNodeTest.php
typo3/sysext/install/Tests/Unit/FolderStructure/DefaultFactoryTest.php
typo3/sysext/install/Tests/Unit/FolderStructure/DirectoryNodeTest.php
typo3/sysext/install/Tests/Unit/FolderStructure/FileNodeTest.php
typo3/sysext/install/Tests/Unit/FolderStructure/LinkNodeTest.php
typo3/sysext/install/Tests/Unit/FolderStructure/RootNodeTest.php
typo3/sysext/install/Tests/Unit/FolderStructure/StructureFacadeTest.php
typo3/sysext/install/Tests/Unit/Service/CoreUpdateServiceTest.php
typo3/sysext/install/Tests/Unit/Status/AbstractStatusTest.php [deleted file]
typo3/sysext/install/Tests/Unit/Status/StatusUtilityTest.php [deleted file]