[!!!][TASK] Remove devlog constants 12/53212/7
authorBenni Mack <benni@typo3.org>
Wed, 14 Jun 2017 16:30:36 +0000 (18:30 +0200)
committerGeorg Ringer <georg.ringer@gmail.com>
Tue, 22 Aug 2017 18:54:31 +0000 (20:54 +0200)
commita6ec631560a55633ae8dacaaf70d4674bd2b96e6
treeeb8d353500d4b2dfdb54993dc56d32cf52037e98
parentdee7da6e9af3dd26ac192657a8f5155a721a695c
[!!!][TASK] Remove devlog constants

Drop three error related constants from bootstrap:
TYPO3_DLOG, TYPO3_ERROR_DLOG, TYPO3_EXCEPTION_DLOG

Removal of these constants has been prepared in v8
and can be done now. This unblocks further logging
related works.

Along the way, the two TYPO3_CONF_VARS "enable_errorDLOG"
and "enable_exceptionDLOG" can be dropped.

The extension scanner can find usages of these constants,
making the patch not less breaking, but usage detection
within extensions is safe and thus helps a lot to spot them.

A new matcher is added to the extension scanner to
scan for usages of global constants.

Resolves: #82162
Releases: master
Change-Id: I6310866738e5cda79a807239846f64996ec76974
Reviewed-on: https://review.typo3.org/53212
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
15 files changed:
typo3/sysext/backend/Classes/Routing/Router.php
typo3/sysext/core/Classes/Core/Bootstrap.php
typo3/sysext/core/Configuration/DefaultConfiguration.php
typo3/sysext/core/Configuration/DefaultConfigurationDescription.php
typo3/sysext/core/Documentation/Changelog/master/Breaking-82162-GlobalErrorConstantsRemoved.rst [new file with mode: 0644]
typo3/sysext/install/Classes/Controller/Action/AbstractAction.php
typo3/sysext/install/Classes/Controller/Action/Ajax/ExtensionScannerScanFile.php
typo3/sysext/install/Classes/ExtensionScanner/Php/Matcher/ConstantMatcher.php [new file with mode: 0644]
typo3/sysext/install/Classes/Service/ClearCacheService.php
typo3/sysext/install/Classes/Service/SilentConfigurationUpgradeService.php
typo3/sysext/install/Configuration/ExtensionScanner/Php/ArrayDimensionMatcher.php
typo3/sysext/install/Configuration/ExtensionScanner/Php/ConstantMatcher.php [new file with mode: 0644]
typo3/sysext/install/Tests/Unit/ExtensionScanner/Php/Matcher/ConstantMatcherTest.php [new file with mode: 0644]
typo3/sysext/install/Tests/Unit/ExtensionScanner/Php/Matcher/Fixtures/ConstantMatcherFixture.php [new file with mode: 0644]
typo3/sysext/scheduler/Classes/Example/TestTask.php