[BUGFIX] FormEngine: Inline getDynamicTabMenu 69/44269/6
authorChristian Kuhn <lolli@schwarzbu.ch>
Sun, 25 Oct 2015 19:45:41 +0000 (20:45 +0100)
committerChristian Kuhn <lolli@schwarzbu.ch>
Wed, 28 Oct 2015 15:01:26 +0000 (16:01 +0100)
commit89ad74e66e3956933bb90d941d71f21a8a2fa595
treefac8cd57da330d009f81e3c2e9b26a3289954af7
parent14e4e0148c1a09da407632e16603d9020493c219
[BUGFIX] FormEngine: Inline getDynamicTabMenu

getDynamicTabMenu() from DocumentTemplate is one of the last pieces
where FormEngine indirectly calls PageRenderer to load JS stuff
instead of returning those via the return structure of FormEngine.
This leads to missing JS if tabs are added via ajax dom modification
and parent has none yet.
The patch copies parts of the code to the FormEngine, re-uses the
template, but strips the method down to FormEngines need. As a result
getTabMenuId() can be deprecated in DocumentTemplate and removed in
ModuleTemplate. The patch then re-routes other usages of
getDynamicTabMenu from DocumentTemplate to ModuleTemplate, removes
another obsolete parameter in there and deprecates the method in
DocumentTemplate.

Resolves: #69729
Releases: master
Change-Id: Ibb94f036d052d5bb9eb4b85efb434b8a05c7755e
Reviewed-on: https://review.typo3.org/44269
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
Reviewed-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Tested-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
12 files changed:
typo3/sysext/backend/Classes/Form/Container/AbstractContainer.php
typo3/sysext/backend/Classes/Form/Container/FlexFormTabsContainer.php
typo3/sysext/backend/Classes/Form/Container/TabsContainer.php
typo3/sysext/backend/Classes/Form/FormResultCompiler.php
typo3/sysext/backend/Classes/Template/DocumentTemplate.php
typo3/sysext/backend/Classes/Template/ModuleTemplate.php
typo3/sysext/compatibility6/Classes/Form/Container/FlexFormTabsContainer.php
typo3/sysext/core/Documentation/Changelog/7.2/Deprecation-65111-getDynTabMenu.rst
typo3/sysext/core/Documentation/Changelog/7.5/Breaking-69795-UnusedDTMTabmenuCodeRemoved.rst
typo3/sysext/core/Documentation/Changelog/master/Deprecation-60712-GetDynamicTabMenu.rst [new file with mode: 0644]
typo3/sysext/linkvalidator/Classes/Report/LinkValidatorReport.php
typo3/sysext/setup/Classes/Controller/SetupModuleController.php