[BUGFIX] Clean-up responsibilities of FAL classes 23/24623/4
authorSteffen Ritter <info@rs-websystems.de>
Sat, 12 Oct 2013 11:04:49 +0000 (13:04 +0200)
committerChristian Kuhn <lolli@schwarzbu.ch>
Sat, 12 Oct 2013 14:51:36 +0000 (16:51 +0200)
commit62338f13bb41b08e94e119b37942ed93eccf2482
tree0be2d13e7cc17c6ed18a7efae6cfb9ecc80b6b75
parent6e04328de543eac21e0610b3c74c81c61b49fe59
[BUGFIX] Clean-up responsibilities of FAL classes

This is a followup for the patch
I6ceeb8db4dd4e470e7c72dcfbc2121093411da75.

The latest change sets missed to adapt
the unit-tests accordingly.

Furthermore due to this change it came to light,
that the active loading option of storages in the file object
may create a recursion issue, if the file is not indexed.
This architectural problem has been removed by making
the constructor argument mandatory and extend the
ResourceFactory to always inject the correct storage.

Releases: 6.2
Resolves: #51528
Change-Id: Ic1561b83f49783e3af1b8f3403e1b8eab84a1380
Reviewed-on: https://review.typo3.org/24623
Reviewed-by: Frans Saris
Tested-by: Frans Saris
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
13 files changed:
typo3/sysext/core/Classes/Resource/AbstractFile.php
typo3/sysext/core/Classes/Resource/Driver/AbstractDriver.php
typo3/sysext/core/Classes/Resource/File.php
typo3/sysext/core/Classes/Resource/Folder.php
typo3/sysext/core/Classes/Resource/Index/FileIndexRepository.php
typo3/sysext/core/Classes/Resource/ResourceFactory.php
typo3/sysext/core/Classes/Resource/Service/IndexerService.php
typo3/sysext/core/Tests/Unit/Resource/Driver/LocalDriverTest.php
typo3/sysext/core/Tests/Unit/Resource/FileTest.php
typo3/sysext/core/Tests/Unit/Resource/ResourceStorageTest.php
typo3/sysext/core/Tests/Unit/Resource/Utility/FileExtensionFilterTest.php
typo3/sysext/frontend/Tests/Unit/ContentObject/ContentObjectRendererTest.php
typo3/sysext/scheduler/Classes/Task/FileIndexingTask.php