[BUGFIX] PHP 7.1 unit tests 43/48843/2
authorChristian Kuhn <lolli@schwarzbu.ch>
Thu, 7 Jul 2016 11:20:20 +0000 (13:20 +0200)
committerChristian Kuhn <lolli@schwarzbu.ch>
Thu, 7 Jul 2016 13:23:32 +0000 (15:23 +0200)
commit53dd37a7793d7a3b9c6d396917d82624f8dacbd4
tree0e668229cc6bc6f8c704e131f8c6341a8f7d53ad
parent954713f3d854ab56f67c07002e318cac99eb012a
[BUGFIX] PHP 7.1 unit tests

Fix a couple of unit tests that fail with PHP 7.1:

* The phpunit mock builder seems to have minor issues mocking
mysqli correctly. This leads so slightly different method
signatures and PHP 7.1 is a bit more picky about those details.
Switching to prophecy on affected tests solves the issue.

* $tsfe->config is initialized as string, calling
$tsfe->config['foo']['bar'] = 'baz'; raises an error
"Error: Cannot use assign-op operators with string offsets".
Cleaning the assignment solves the issue.

Change-Id: I81f3a75e5b682064c6a43f989f0cf862e2d1bc6e
Resolves: #76980
Releases: master, 7.6
Reviewed-on: https://review.typo3.org/48843
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
typo3/sysext/core/Tests/Unit/Database/DatabaseConnectionTest.php
typo3/sysext/frontend/Tests/Unit/Controller/TypoScriptFrontendControllerTest.php
typo3/sysext/indexed_search/Tests/Unit/IndexerTest.php