[BUGFIX] FormEngine: Fix keepItems, addItems and removeItems handling 70/44570/4
authorMorton Jonuschat <m.jonuschat@mojocode.de>
Fri, 6 Nov 2015 10:07:46 +0000 (11:07 +0100)
committerWouter Wolters <typo3@wouterwolters.nl>
Fri, 6 Nov 2015 14:41:46 +0000 (15:41 +0100)
commit2da8b474a37f987706b511250299ccc887c9f80c
tree5c8a60eb7eed049d13d58d3cca56219b86123d74
parentefa1df05b3bba62a09bf118bbabf3fcb4e406d2f
[BUGFIX] FormEngine: Fix keepItems, addItems and removeItems handling

With the FormEngine rewrite the evaluation order and handling of the
options changed. This patch restores the previous order, adds tests
for the addItems handling as well as for the execution order of
keepItems, addItems and removeItems.

In addition the behavior of keepItems with an empty list of items has
been restored.

Resolves: #70956
Releases: master
Change-Id: I44b3036e2ba4dd824037aa689543dc2f1c653b93
Reviewed-on: https://review.typo3.org/44570
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
typo3/sysext/backend/Classes/Form/FormDataProvider/AbstractItemProvider.php
typo3/sysext/backend/Classes/Form/FormDataProvider/TcaSelectItems.php
typo3/sysext/backend/Classes/Form/FormDataProvider/TcaSelectTreeItems.php
typo3/sysext/backend/Tests/Unit/Form/FormDataProvider/TcaSelectItemsTest.php
typo3/sysext/core/Documentation/Changelog/master/Important-70956-BehaviorOfPageTCconfigOptionsKeepItemsAddItemsAndRemoveItemsChanged.rst [new file with mode: 0644]