[!!!][TASK] Remove deprecated code from core Crypto/PasswordHashing 97/59197/6
authorChristian Kuhn <lolli@schwarzbu.ch>
Tue, 18 Dec 2018 18:05:53 +0000 (19:05 +0100)
committerAnja Leichsenring <aleichsenring@ab-softlab.de>
Wed, 19 Dec 2018 07:45:21 +0000 (08:45 +0100)
commit028d3420de7d28cc5dadcf7f6d7eb60a045b916d
treeac1c72715178a7d434ca96e2aa3d8bf9bbb9fb5a
parentcd55808b1ac40b943f12fa07277fdef73651ac11
[!!!][TASK] Remove deprecated code from core Crypto/PasswordHashing

Removed classes:
TYPO3\CMS\Core\Crypto\PasswordHashing\AbstractComposedSalt

Removed interfaces:
TYPO3\CMS\Core\Crypto\PasswordHashing\ComposedPasswordHashInterface
TYPO3\CMS\Core\Crypto\PasswordHashing\ExtensionManagerConfigurationUtility
TYPO3\CMS\Core\Crypto\PasswordHashing\SaltedPasswordService
TYPO3\CMS\Core\Crypto\PasswordHashing\SaltedPasswordsUtility

Removed class aliases:
TYPO3\CMS\Saltedpasswords\Salt\AbstractSalt
TYPO3\CMS\Saltedpasswords\Salt\AbstractComposedSalt
TYPO3\CMS\Saltedpasswords\Salt\Argon2iSalt
TYPO3\CMS\Saltedpasswords\Salt\BcryptSalt
TYPO3\CMS\Saltedpasswords\Salt\BlowfishSalt
TYPO3\CMS\Saltedpasswords\Salt\ComposedSaltInterface
TYPO3\CMS\Saltedpasswords\Salt\Md5Salt
TYPO3\CMS\Saltedpasswords\Salt\SaltFactory
TYPO3\CMS\Saltedpasswords\Salt\SaltInterface
TYPO3\CMS\Saltedpasswords\Salt\Pbkdf2Salt
TYPO3\CMS\Saltedpasswords\Salt\PhpassSalt
TYPO3\CMS\Saltedpasswords\SaltedPasswordsService
TYPO3\CMS\Saltedpasswords\Utility\ExensionManagerConfigurationUtility
TYPO3\CMS\Saltedpasswords\Utility\SaltedPasswordsUtility

Removed methods:
TYPO3\CMS\Core\Crypto\PasswordHashing\Argon2iPasswordHash->getOptions()
TYPO3\CMS\Core\Crypto\PasswordHashing\Argon2iPasswordHash->setOptions()
TYPO3\CMS\Core\Crypto\PasswordHashing\BcryptPasswordHash->getOptions()
TYPO3\CMS\Core\Crypto\PasswordHashing\BcryptPasswordHash->setOptions()
TYPO3\CMS\Core\Crypto\PasswordHashing\BlowfishSalt->getHashCount()
TYPO3\CMS\Core\Crypto\PasswordHashing\BlowfishSalt->getMaxHashCount()
TYPO3\CMS\Core\Crypto\PasswordHashing\BlowfishSalt->getMinHashCount()
TYPO3\CMS\Core\Crypto\PasswordHashing\BlowfishSalt->getSaltLength()
TYPO3\CMS\Core\Crypto\PasswordHashing\BlowfishSalt->getSetting()
TYPO3\CMS\Core\Crypto\PasswordHashing\BlowfishSalt->setHashCount()
TYPO3\CMS\Core\Crypto\PasswordHashing\BlowfishSalt->setMaxHashCount()
TYPO3\CMS\Core\Crypto\PasswordHashing\BlowfishSalt->setMinHashCount()
TYPO3\CMS\Core\Crypto\PasswordHashing\Md5PasswordHash->getSetting()
TYPO3\CMS\Core\Crypto\PasswordHashing\Md5PasswordHash->getSaltLength()
TYPO3\CMS\Core\Crypto\PasswordHashing\Pbkdf2PasswordHash->getHashCount()
TYPO3\CMS\Core\Crypto\PasswordHashing\Pbkdf2PasswordHash->getMaxHashCount()
TYPO3\CMS\Core\Crypto\PasswordHashing\Pbkdf2PasswordHash->getMinHashCount()
TYPO3\CMS\Core\Crypto\PasswordHashing\Pbkdf2PasswordHash->getSaltLength()
TYPO3\CMS\Core\Crypto\PasswordHashing\Pbkdf2PasswordHash->getSetting()
TYPO3\CMS\Core\Crypto\PasswordHashing\Pbkdf2PasswordHash->setHashCount()
TYPO3\CMS\Core\Crypto\PasswordHashing\Pbkdf2PasswordHash->setMaxHashCount()
TYPO3\CMS\Core\Crypto\PasswordHashing\Pbkdf2PasswordHash->setMinHashCount()
TYPO3\CMS\Core\Crypto\PasswordHashing\PhpassPasswordHash->getHashCount()
TYPO3\CMS\Core\Crypto\PasswordHashing\PhpassPasswordHash->getMaxHashCount()
TYPO3\CMS\Core\Crypto\PasswordHashing\PhpassPasswordHash->getMinHashCount()
TYPO3\CMS\Core\Crypto\PasswordHashing\PhpassPasswordHash->getSaltLength()
TYPO3\CMS\Core\Crypto\PasswordHashing\PhpassPasswordHash->getSetting()
TYPO3\CMS\Core\Crypto\PasswordHashing\PhpassPasswordHash->setHashCount()
TYPO3\CMS\Core\Crypto\PasswordHashing\PhpassPasswordHash->setMaxHashCount()
TYPO3\CMS\Core\Crypto\PasswordHashing\PhpassPasswordHash->setMinHashCount()

Protected methods:
TYPO3\CMS\Core\Crypto\PasswordHashing\BlowfishPasswordHash->isValidSalt()
TYPO3\CMS\Core\Crypto\PasswordHashing\BlowfishPasswordHash->base64Encode()
TYPO3\CMS\Core\Crypto\PasswordHashing\Md5PasswordHash->isValidSalt()
TYPO3\CMS\Core\Crypto\PasswordHashing\Md5PasswordHash->base64Encode()
TYPO3\CMS\Core\Crypto\PasswordHashing\Pbkdf2PasswordHash->isValidSalt()
TYPO3\CMS\Core\Crypto\PasswordHashing\Pbkdf2PasswordHash->base64Encode()
TYPO3\CMS\Core\Crypto\PasswordHashing\Pbkdf2PasswordHash->base64Decode()
TYPO3\CMS\Core\Crypto\PasswordHashing\PhpassPasswordHash->isValidSalt()
TYPO3\CMS\Core\Crypto\PasswordHashing\PhpassPasswordHash->base64Encode()

Removed static methods:
TYPO3\CMS\Core\Crypto\PasswordHashing\PasswordHashFactory::determineSaltingHashingMethod()
TYPO3\CMS\Core\Crypto\PasswordHashing\PasswordHashFactory::getSaltingInstance()
TYPO3\CMS\Core\Crypto\PasswordHashing\PasswordHashFactory::setPreferredHashingMethod()

Second method argument dropped:
TYPO3\CMS\Core\Crypto\PasswordHashing\BlowfishPasswordHash->getHashedPassword()
TYPO3\CMS\Core\Crypto\PasswordHashing\Md5PasswordHash->getHashedPassword()
TYPO3\CMS\Core\Crypto\PasswordHashing\Pbkdf2PasswordHash->getHashedPassword()
TYPO3\CMS\Core\Crypto\PasswordHashing\PhpassPasswordHash->getHashedPassword()

Ignored options:
$GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['ext/saltedpasswords']['saltMethods']

Dropped constants:
TYPO3\CMS\Core\Crypto\PasswordHashing\BlowfishPasswordHash::ITOA64
TYPO3\CMS\Core\Crypto\PasswordHashing\BlowfishPasswordHash::HASH_COUNT
TYPO3\CMS\Core\Crypto\PasswordHashing\BlowfishPasswordHash::MAX_HASH_COUNT
TYPO3\CMS\Core\Crypto\PasswordHashing\BlowfishPasswordHash::MIN_HASH_COUNT
TYPO3\CMS\Core\Crypto\PasswordHashing\Md5PasswordHash::ITOA64
TYPO3\CMS\Core\Crypto\PasswordHashing\Pbkdf2PasswordHash::ITOA64
TYPO3\CMS\Core\Crypto\PasswordHashing\Pbkdf2PasswordHash::HASH_COUNT
TYPO3\CMS\Core\Crypto\PasswordHashing\Pbkdf2PasswordHash::MAX_HASH_COUNT
TYPO3\CMS\Core\Crypto\PasswordHashing\Pbkdf2PasswordHash::MIN_HASH_COUNT
TYPO3\CMS\Core\Crypto\PasswordHashing\PhpassPasswordHash::ITOA64
TYPO3\CMS\Core\Crypto\PasswordHashing\PhpassPasswordHash::HASH_COUNT
TYPO3\CMS\Core\Crypto\PasswordHashing\PhpassPasswordHash::MAX_HASH_COUNT
TYPO3\CMS\Core\Crypto\PasswordHashing\PhpassPasswordHash::MIN_HASH_COUNT

Removed language file aliases:
EXT:saltedpasswords/Resources/Private/Language/locallang.xlf
EXT:saltedpasswords/Resources/Private/Language/locallang_em.xlf

Change-Id: Ia6a18209f104ca1abc6981508fb8b640ef2eb1a3
Resolves: #87203
Releases: master
Reviewed-on: https://review.typo3.org/59197
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
35 files changed:
typo3/sysext/core/Classes/Crypto/PasswordHashing/AbstractComposedSalt.php [deleted file]
typo3/sysext/core/Classes/Crypto/PasswordHashing/Argon2iPasswordHash.php
typo3/sysext/core/Classes/Crypto/PasswordHashing/BcryptPasswordHash.php
typo3/sysext/core/Classes/Crypto/PasswordHashing/BlowfishPasswordHash.php
typo3/sysext/core/Classes/Crypto/PasswordHashing/ComposedPasswordHashInterface.php [deleted file]
typo3/sysext/core/Classes/Crypto/PasswordHashing/ExtensionManagerConfigurationUtility.php [deleted file]
typo3/sysext/core/Classes/Crypto/PasswordHashing/Md5PasswordHash.php
typo3/sysext/core/Classes/Crypto/PasswordHashing/PasswordHashFactory.php
typo3/sysext/core/Classes/Crypto/PasswordHashing/Pbkdf2PasswordHash.php
typo3/sysext/core/Classes/Crypto/PasswordHashing/PhpassPasswordHash.php
typo3/sysext/core/Classes/Crypto/PasswordHashing/SaltedPasswordService.php [deleted file]
typo3/sysext/core/Classes/Crypto/PasswordHashing/SaltedPasswordsUtility.php [deleted file]
typo3/sysext/core/Classes/Localization/LocalizationFactory.php
typo3/sysext/core/Documentation/Changelog/master/Breaking-87193-DeprecatedFunctionalityRemoved.rst
typo3/sysext/core/Migrations/Code/ClassAliasMap.php
typo3/sysext/core/Migrations/Code/LegacyClassesForIde.php
typo3/sysext/core/Resources/Private/Language/locallang_deprecated_saltedpasswords.xlf [deleted file]
typo3/sysext/core/Resources/Private/Language/locallang_deprecated_saltedpasswords_em.xlf [deleted file]
typo3/sysext/core/Tests/Functional/Crypto/PasswordHashing/Fixtures/be_users.xml [deleted file]
typo3/sysext/core/Tests/Functional/Crypto/PasswordHashing/Fixtures/fe_users.xml [deleted file]
typo3/sysext/core/Tests/Functional/Crypto/PasswordHashing/SaltedPasswordServiceTest.php [deleted file]
typo3/sysext/core/Tests/Functional/Crypto/PasswordHashing/SaltedPasswordsUtilityTest.php [deleted file]
typo3/sysext/core/Tests/UnitDeprecated/Crypto/PasswordHashing/Argon2iPasswordHashTest.php [deleted file]
typo3/sysext/core/Tests/UnitDeprecated/Crypto/PasswordHashing/BcryptPasswordHashTest.php [deleted file]
typo3/sysext/core/Tests/UnitDeprecated/Crypto/PasswordHashing/BlowfishPasswordHashTest.php [deleted file]
typo3/sysext/core/Tests/UnitDeprecated/Crypto/PasswordHashing/Md5PasswordHashTest.php [deleted file]
typo3/sysext/core/Tests/UnitDeprecated/Crypto/PasswordHashing/PasswordHashFactoryTest.php [deleted file]
typo3/sysext/core/Tests/UnitDeprecated/Crypto/PasswordHashing/Pbkdf2PasswordHashTest.php [deleted file]
typo3/sysext/core/Tests/UnitDeprecated/Crypto/PasswordHashing/PhpassPasswordHashTest.php [deleted file]
typo3/sysext/install/Configuration/ExtensionScanner/Php/ArrayDimensionMatcher.php
typo3/sysext/install/Configuration/ExtensionScanner/Php/ClassConstantMatcher.php
typo3/sysext/install/Configuration/ExtensionScanner/Php/ClassNameMatcher.php
typo3/sysext/install/Configuration/ExtensionScanner/Php/MethodArgumentDroppedMatcher.php
typo3/sysext/install/Configuration/ExtensionScanner/Php/MethodCallMatcher.php
typo3/sysext/install/Configuration/ExtensionScanner/Php/MethodCallStaticMatcher.php